docs(inline edit): Updates images for v6.#4613
Conversation
|
@edonehoo wondering if the GIF should be in a different place? seems a little odd to me that the GIF showing the behavior of the inline edit is placed right after "When not to use" and "For example, in an edit modal." (this makes it seem like the GIF is showing that incorrect example) |
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
a couple notes related to opening a Docs follow up
And just a couple small things to try and adjust for this pr (gif size, missing tooltip)!
There was a problem hiding this comment.
the gif came out teeny tiny 😆 🤏
There was a problem hiding this comment.
So yeah if it's showing valid behavior then I agree with you that's a weird placement currently. I think there should really be a Behavior section that holds that gif, where we describe the interaction.. Hm, do you want to create an h2 ##Behavior between the Usage and Variations section, and just stick the gif there for this pr? I could add the content in a Docs follow up
There was a problem hiding this comment.
Just adding a note for Docs here since it's contextually related, but might want to update the content to call out the specific icon names (right now we just say check and close, but I think we should do fa-check or whatever)
There was a problem hiding this comment.
Also note for Docs, i think some of the bullet points related to this aren't applicable anymore, need to review.
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
no edits here, thanks!
4 participants
Closes #4530